Skip to content

Lowrank sum params - #50

Merged
liuanji merged 46 commits into
mainfrom
lowrank-sum-params
Aug 1, 2026
Merged

liuanji merged 46 commits into
mainfrom
lowrank-sum-params

Conversation

@liuanji

@liuanji liuanji commented Aug 1, 2026

Copy link
Copy Markdown
Member

No description provided.

liuanji added 30 commits July 29, 2026 18:20
…parameter handling

- Removed redundant kernels and consolidated logic in the low-rank forward computation.
- Introduced a new `tie_external` option in `LowRankSumParams` to allow sharing of external factors across tied nodes, optimizing memory usage and performance.
- Updated the forward and backward methods to accommodate the new parameter tying mechanism.
- Added tests to validate the behavior of tied external parameters and ensure gradient accumulation is correctly implemented.
- Improved documentation and comments for clarity on kernel behavior and parameter interactions.
liuanji added 16 commits July 31, 2026 10:25
… optimize shared memory usage

- Removed the sigma parameter from the blockscale_forward kernel and related functions to streamline the interface.
- Simplified the gate_pass and accum_z functions by eliminating unnecessary parameters and unrolled loops.
- Optimized shared memory allocation and access patterns for improved performance.
- Adjusted kernel launch configurations to reflect the changes in parameters and memory layout.
- Enhanced the normalizer's operand computation to reduce redundant memory accesses.
@liuanji
liuanji merged commit 87e6367 into main Aug 1, 2026
2 checks passed
@liuanji
liuanji deleted the lowrank-sum-params branch August 1, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant